View Single Post
Old 04-19-2009   #20
ennuilg
Full Member
 
Join Date: Aug 2008
Posts: 126
Default Re: Scorchio! 2 - Official Thread

I've committed another alpha this evening...

Torment the Weak has been an absolutely nightmare! There is, as far as I can see, no way to make it work perfectly in a stylish and elegant manner, for the following reasons:

1. Only Judgements cast by paladins with the Judgement of the Just talent trigger TtW. There is no way, using the combat log information or UnitDebuff() to tell if a judgement (cast) on a mob is talented or not. There is no debuff for JotJ, not for TtW.

2. DKs can choose talents to change the duration of Frost Fever. Again, there is no way of telling from the combat log how long the FF should last. UnitDebuff() will tell us though.

In reverse order, I've solved (2) by running AuraScan("target") each time a recognised debuff is thrown on a mob. This should actually tighten the accuracy of all the information on your current target, but I hope it doesn't have a detrimental effect on performance.

In order to come close to solving (1), I've had to introduce a Paladin "Whitelist". In the options for Scorchio! 2, under Torment the Weak, there is now a button for "Add Paladin", where the user has to target a pally known to be talented with JotJ and add them so the addon doesn't ignore their judgements. (This whitelist is remembered, so you only need to add your guild tankadin's once.)

This works, as far as it's been tested so far. If you're grouped with the paladin who cast the judgement, it will even work when you reenter combat/change targets, but if you're not grouped, the UnitDebuff() will not tell you who cast the judgement, so the addon errs on the side of caution and ignores any existing ones on the mob.

It's imperfect and annoying. Blizzard should just add a TtW debuff and be done with it!

Please test the alpha and let me know if it works as you expect...

Oh, this commit should also fix the "TtW bars hanging around" issue once and for all - by changing to timed bars, the same code is now used as has been working flawlessly for every other type of buff, so fingers crossed!
ennuilg is offline   Reply With Quote