PeriodicTable-3.1

[Shadoweric]

Alright. Can I ask why you'd want to separate talents that give an ability from those that don't?

[yssaril]

i think for completeness one would want set of default spells (with earliest level), a set of talented spells, and just talents (this would include talent that give spells too i would assume). that way all your bases are covered.

[Arrowmaster]

Originally Posted by Shadoweric

When a talent gives a new ability, the spell ID for the ability/resulting buff is the same as the talent. Using the Divine Sacrifice example above, you can find the spell ID 64205, which Requital gave above, by going to Database -> Spells -> Talents -> Paladins.

Class skills function the same way: if one generates, say, a debuff on a mob, the spell ID of that debuff is the same as the ability that's on the player's toolbar.

So I'm still not sure where the problem is.

This is wrong. That may be the default behavior but not all spells act that way. Hell look at palidin healing spells, I'm fairly certain almost all of them use a different spell ID for the heal event in the combat log than the spells in the spellbook.

[Shadoweric]

I'd have to check, but I'm prety sure they do use the same ID (FoL and HL are straight-forward and good examples of that). What's likely different is when an ability generates multiple effects. Beacon of Light will generate 2 buffs: Beacon of Light, which uses the same ID again, and Light's Beacon, which is another one.

Or to use a talent that gives an ability, Killing Spree for a rogue. The ability you get uses the same ID as the talent, and so does the buff the rogue gets (I did check that via combat log), but the extra attacks generated are 2 different spell IDs.

I spent a decent amount of time identifying all this when looking for all possible player-generated bleed effects in the game (I was an Assassination rogue: Hunger for Blood needs a bleed), in order to quickly know via addons when I could use Hunger for Blood without applying my own bleed first


Either way, I understand now that it'd be preferable to separate talents that give and ability from those that don't. Fair enough. The data is there though, if not easily sorted.

[Elkano]

I don't think talents are in PT3.1 at all (besides those for druids and the mage's frost tree that give spells). So this isn't about separating talents into those that give spells and those that don't.
It's simply that wowhead doesn't list the first rank for spells learend via talents in their class spell list. Thus these would have to be mined from the talent list but there is no easy way to select exactly these talents.
That's why the dataminer has the ability to force-insert additional data into sets which is currently used for these talents but is only ste up for druids and the mage's frost tree.
So if you can provide me with a list of talent/spell ids from each talent tree that are rank 1 of some class spell, I can add them to the dataminer in order to get them into the classspell sets.

I'm currently in the process of redesigning some datasets (eg instance loot) and the dataminer so I don't have time to do it myself :/

[Azethoth]

What Elkano said.

The miner code to handle these single exceptions:

-- Adds items not mineable / easily mineable to the end of a set
-- For instance rank 1 talents to ClassSpell
local additionalSetItems = {
	["ClassSpell.Druid.Balance"] = ",-5570:30,-33831:50,-50516:50,-48505:60",
	["ClassSpell.Druid.Feral Combat"] = ",-49377:30,-33878:50,-33876:50,-50334:60",
	["ClassSpell.Druid.Restoration"] = ",-17116:30,-18562:40,-48438:60",
	["ClassSpell.Mage.Frost"] = ",-12472:20,-11958:30,-11426:40,-31687:50,-44572:60",
	["ClassSpell.Paladin.Protection"] = ",-64205:20",
	["ClassSpell.Rogue.Combat"] = ",-51690:60",
}

So please post your rank 1 talents so they can get added to the class spells.

[Azethoth]

All trinkets should get mined now. Needed splitting out on quality.

I noticed an error in Currency items. It has some instances of double commas"...,,...". Seems wrong.

[pompachomp]

When are the drops from ToC and Onyxia going to get included into LPT?