Postal (was GMail2): Updated

[LaoTseu]

More details (in case it helps).

I'm CTRL-Click a nave for a toon that have multiple mails with multiple attachments. Sometimes, only the first one of only one of the mail is extracted.

Excample: 3 mail, mail 1 = 12 attachments, mail 4 = 12 attachments, mail 9 = 9 attachments.

Result (this has just happened to me): 9 attachments from mail 9 extracted, 1 attachment from mail 4 extracted, 12 attachments from mail 1 extracted. 11 attachments from mail 4 were left in the mail box.

[Xinhuan]

Ok, looking at the code again, and using your description to narrow down the culprit behavior (that is, mailIndex variable is decrementing when it should not be), this behavior can happen if your opening speed is too fast, and is a bug.

Go open Select.lua and comment out lines 293-296 and add one additional line, that is after commenting out those 4 lines and adding the additional line, it should look like this:

PHP Code:

            else
                selectedMail[mailIndex] = nil
                if lastItem and lastItem ~= GetInboxNumItems() then
                    -- the last attachment or gold taken auto deleted the mail so move on to the next mail
                    mailIndex = mailIndex - 1
                    attachIndex = ATTACHMENTS_MAX_RECEIVE
                    lastItem = nil
                    return self:ProcessNext() -- tail call
                end
                --mailIndex = mailIndex - 1
                --attachIndex = ATTACHMENTS_MAX_RECEIVE
                --lastItem = nil
                --return self:ProcessNext() -- tail call
                updateFrame:Show()
            end 


Clearly a logic error, since the if-check doesn't matter at all if the contents of the IF check (lines 288-291) is the same as the stuff outside the check (293-296).

See if that helps. The same logic error is also in OpenAll.lua.

[LaoTseu]

I've made the changes to my local copy, I'll let you know if I see an improvement but since it's a thing that doesn't happen all the time, it may be a while before I have anything to report.

[Kharthus]

Just did a small test with my modified OpenAll and it seems to be working. I'll keep watching to see if anything bad happens.

[LaoTseu]

4 days later, the problem has not occurred again so I think the fix is good.

I did had a few instances of the mail stopping being open even though there is one remaining free slot in my bags even if keep free space is set to 0.

[Xinhuan]

Yep, the free space left option is still somewhat new and needs a bit of tweaking.

[Kharthus]

Found another very small bug:

The tooltips for multi item mails only show the item icons for the 1st ten items. The 11th and 12th item have no icons.

[Xinhuan]

Originally Posted by Kharthus

Found another very small bug:

The tooltips for multi item mails only show the item icons for the 1st ten items. The 11th and 12th item have no icons.

Can't really be fixed, the default UI's tooltip only supports up to 10 embedded icons.

See post #412 through #416 (link to them here) if you want to know why using embedded textures in fontstrings doesn't work well either (screenshots attached in post).
http://forums.wowace.com/showthread....108#post196108

[Kharthus]

When I try to AutoOpen all my messages it will hang on any regular mail with text from another player and will refuse to move past that message until I manually go delete that message.