Go Back   WowAce Forums > General > Lua Code Discussion
Lua Code Discussion You scared? Terrified. Mortified. Petrified. Stupefied... by [coding].

Reply
 
Thread Tools
Old 10-15-2010   #91
Allara
Senior Member
 
Allara's Avatar
 
Join Date: Feb 2005
Posts: 444
Default Re: New and broken stuff with Cataclysm

Yeah, that's how I found it. Added a check for thrown enchant to Energized.
Allara is offline   Reply With Quote
Old 10-16-2010   #92
Adirelle
Legendary Member
 
Adirelle's Avatar
 
Join Date: Dec 2006
Posts: 2,386
Default Re: New and broken stuff with Cataclysm

GetCurrencyListInfo has been changed from :

Quote:
name, isHeader, isExpanded, isUnused, isWatched, count, extraCurrencyType, icon, itemID = GetCurrencyListInfo(index)
to :

Quote:
name, isHeader, isExpanded, isUnused, isWatched, count, icon, itemID = GetCurrencyListInfo(index)
The "extraCurrencyType" return value is gone. The proper icon is returned for honor and conquest points.

PS: I didn't verified itemID actually.
__________________
Author of AdiButtonAuras, AdiBags, Squire2 and several other addons.

Each time you hit your "copy" command with a block of code, think about a way to refactor it so it did what you want without using the "paste" command.
Adirelle is offline   Reply With Quote
Old 10-16-2010   #93
Xinhuan
Asian Sheep Lover
 
Xinhuan's Avatar
 
Join Date: Aug 2007
Location: Singapore
Posts: 4,033
Default Re: New and broken stuff with Cataclysm

So, Live servers, PTR servers and Beta servers all have a different returns for GetCurrencyListInfo()?
__________________
Author/Maintainer of Postal, Omen3, GemHelper, BankItems, WoWEquip, GatherMate, Routes, HandyNotes and some others.
Xinhuan is offline   Reply With Quote
Old 10-16-2010   #94
Adirelle
Legendary Member
 
Adirelle's Avatar
 
Join Date: Dec 2006
Posts: 2,386
Default Re: New and broken stuff with Cataclysm

Quote:
Originally Posted by Xinhuan View Post
So, Live servers, PTR servers and Beta servers all have a different returns for GetCurrencyListInfo()?
I reported the live behavior. Can't tell for PTR. I can check beta.
__________________
Author of AdiButtonAuras, AdiBags, Squire2 and several other addons.

Each time you hit your "copy" command with a block of code, think about a way to refactor it so it did what you want without using the "paste" command.
Adirelle is offline   Reply With Quote
Old 10-16-2010   #95
Arkayenro
Hero Member
 
Join Date: Dec 2006
Posts: 664
Default Re: New and broken stuff with Cataclysm

Quote:
Originally Posted by Adirelle View Post
I reported the live behavior. Can't tell for PTR. I can check beta.
on live the itemID is always nil. its causing errors in blizzards own code because they use that to generate the chatlink.

you would hope they chose a better way to reference things than their position in a local list (which they seem to like doing a lot).
Arkayenro is offline   Reply With Quote
Old 10-16-2010   #96
kolenka
Newbie
 
Join Date: Nov 2008
Posts: 8
Default Re: New and broken stuff with Cataclysm

Quote:
Originally Posted by Arkayenro View Post
on live the itemID is always nil. its causing errors in blizzards own code because they use that to generate the chatlink.

you would hope they chose a better way to reference things than their position in a local list (which they seem to like doing a lot).
There is a concept of a currency ID, but there's no way to get that ID programmatically... and IDs for currencies you haven't seen will return nil results, even if the currency is valid (with the exception of the Archaeology currencies).

The itemID is actually one of 4 unknowns that are returned...

unk1, unk2, unk3, unk4 = 0 (usually), nil, 0, nil.

unk1 is 400000 for the new Raid/BG currencies, and 10 for the new cooking awards. Unk2-4 are not returning anything unique at the moment.

This behavior is the same across live, PTR and Beta.
__________________
Author of MrCurrency, and MrTrader
kolenka is offline   Reply With Quote
Old 10-16-2010   #97
Lombra
Senior Member
 
Lombra's Avatar
 
Join Date: Jan 2006
Location: Sweden
Posts: 415
Default Re: New and broken stuff with Cataclysm

Calling chatFrame:SetMaxLines(numLines) will now clear all messages in the chat frame. This was driving me nuts until I finally found out...
__________________
Grab your sword and fight the Horde!

Shattered Hand-EU
Lombra is offline   Reply With Quote
Old 10-16-2010   #98
durcyn
Hero Member
 
durcyn's Avatar
 
Join Date: Sep 2008
Posts: 938
Default Re: New and broken stuff with Cataclysm

SPELL_AURA_BROKEN and SPELL_AURA_BROKEN_SPELL subevents are missing from COMBAT_LOG_EVENT_UNFILTERED if you were trying to do anything meaningful with them. bug reported on US bug report forum here: http://forums.worldofwarcraft.com/th...272900859172#0
durcyn is offline   Reply With Quote
Old 10-16-2010   #99
Phanx
Seal Cub Clubbing Club
 
Phanx's Avatar
 
Join Date: May 2005
Location: United States
Posts: 8,187
Default Re: New and broken stuff with Cataclysm

Quote:
Originally Posted by Lombra View Post
Calling chatFrame:SetMaxLines(numLines) will now clear all messages in the chat frame. This was driving me nuts until I finally found out...
It's always done that.
__________________
Author/maintainer of Grid, PhanxChat, and many more. | PM me on CurseForge
Troubleshoot an addon | Turn any code into an addon | More addon resources
Need help with your code? Attach or paste your whole, real files.
Please don't PM me about addon bugs, requests, or code help. Post a comment, ticket, or thread instead!
Phanx is offline   Reply With Quote
Old 10-17-2010   #100
Lombra
Senior Member
 
Lombra's Avatar
 
Join Date: Jan 2006
Location: Sweden
Posts: 415
Default Re: New and broken stuff with Cataclysm

Quote:
Originally Posted by Phanx View Post
It's always done that.
Really? I was going crazy wondering why the hell my print debugging wouldn't show up!
__________________
Grab your sword and fight the Horde!

Shattered Hand-EU
Lombra is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 07:58 AM.