How to reduce chance of UI taint from StaticPopupDialogs

[dpsgnome]

Original discussion: http://www.tukui.org/forums/topic.php?id=15823


Basically, when you create a StaticPopupDialog table, set the following member like this:

StaticPopupDialogs["MY_DIALOG_NAME"]={
  preferredIndex = 3
  -- and then the rest of your definition
}

Basically, there are a total of 4 StaticPopupDialogs resources. 1 and 2 are the ones normally getting used by the Blizzard UI. If you "prefer" #3 (may end up in #4 if #3 is already showing), chances are much better to avoid tainting UI code that involves StaticPopupDialogs (notably the glyph UI)


Alternatively, you may want to use Torhal's http://www.wowace.com/addons/libdialog-1-0/ which always avoids taint, and extends the dialogs with a bit more functionality.


And, no, this does not solve all tainting issues. There's plenty more to go around. But it plugs one hole.

[funkydude]

Awesome, thanks for the heads up Mikk!

[Dridzt]

That's basically what Rabbit said more than a year ago...

[Elsia]

A recount ticket? Neat.

[dpsgnome]

Yes, the glyph frame can un-taint itself somehow.

Basically, if you have the glyph frame open, and hit N+N to close it, and then open it again, it's tainted.

But if you [Esc] out of the glyph frame, and then open it again, it untaints itself.


Obviously just N+N doesn't automagically taint the frame, the taint has to come from somehwere. We haven't quite figured it out yet.

My personal guess is that timed popups (like Summon Accept + EPGP's "don't have multiple people change stuff!") is involved. Foxlit & Sylv were being suspicious about popups that read the .data / .data2 members, like loot & instance save accept dialogs.

[dpsgnome]

Uh. Except now it happened straight on startup with no popups involved.

Edit: Nailed it. Receiving a whisper causes this strain of taint for me.

[Carsight]

Recently a huge amount of talent taints are occured, now here is the problem:

whoever calls 'StaticPopup_Show' when PlayerTalentFrame is hidden will cause this taint, you can try it

Even this macro will cause the taint when PlayerTalentFrame is hidden "/run StaticPopup_Show('PARTY_INVITE',"a")" , and make you have to reload ui when you want to change your talent

so, all addons author, don't use blizzard's StaticPopup systeam and try to use others

[8tImER]

Necro!


At least since 5.0, probably even before that, it's better to use

preferredIndex=STATICPOPUPS_NUMDIALOGS

than 3. STATICPOPUPS_NUMDIALOGS is 4, currently.

[Carsight]

Yes, i know this thread, but since macro "/run StaticPopup_Show('PARTY_INVITE',"a")" will also taint, it's not the 'preferredIndex' who taint it, we just need to avoid using blz's staticpopup systeam
even /run StaticPopup4.which = '1' will taint talentUI