GetGuildInfo("unit") lua error

[gnomi123]

Hello, people out there
Im pretty new to addonprogramming, but i think i got the concepts pretty well now. But an Error of the BlizzardUI is bothering me, called:

Message: ...face\AddOns\Blizzard_InspectUI\InspectGuildFram e.lua:18: Usage: GetGuildInfo("unit")

I already spended a lot time searching for solutions on google, but i wasnt able to find any. I know that the Error is caused by my NotifyInspect() call, but i really cant see what to do against it. I securehooked the function to make sure its my own call I get the response of and I dealt with the inconsistence of the function too, using a queue.

But this Error is still showing up, I heared about the Addon InspectFix which should fix this for all addons, but I cant really get its point in the code.

So please, help me
(I dont think that you will need my code for this, since its a trouble with some Blizz-stuff, but you can still request it from me, ofc)

Another problem that i just discovered is that GetInventoryItemLink(name, slot) sometimes returns the mogged item, not the real one. But only sometimes.

[Farmbuyer]

Known Blizzard bug. Install

http://www.curse.com/addons/wow/inspectfix

as a workaround.

[gnomi123]

Like I said, I know that addon. But I would like to know what its code does to avoid it, exactly. And I cant force everyone who uses my addon to install InspectFix too, can I?
As a workaround, I simply used SetCVar("ScriptErrors", "0") to prevent any luaerrors to show up.
What still is remaining is the problem that - sometimes - Im not getting back the real item, but the mogged one. Is there any way to prevent this?

[Seerah]

Originally Posted by gnomi123

But I would like to know what its code does to avoid it, exactly.

Did you open it up to look at the code?

As a workaround, I simply used SetCVar("ScriptErrors", "0") to prevent any luaerrors to show up.

Don't do that!

[Ketho]

I don't know what InspectFix does exactly, but ..

in one of my addons I use a workaround, by setting InspectFrame.unit to yourself
This should at least prevent InspectGuildFrame_Update() line 18 from giving an error

Setting it to "player" should be safer than e.g. "none", "target" or the applicable unit id, since otherwise it still has a chance to give an error a bit further up at line 25

The idea is that it doesn't really matter what unit id it's set to, as long as it won't give an error, and since there isn't any actual inspecting going on anyway

1. Blizzard_InspectUI is loaded and InspectFrame is shown -> don't NotifyInspect()
   
2. Blizzard_InspectUI is loaded and InspectFrame is not shown -> NotifyInspect(), set InspectFrame.unit to "player"
3. Blizzard_InspectUI is not loaded -> NotifyInspect()

This is my example code:

if CanInspect(unit) then
	if InspectFrame then
		if not InspectFrame:IsShown() then
			InspectFrame.unit = "player"
			NotifyInspect(unit)
		end
	else
		NotifyInspect(unit)
	end
end

This thread's subject is only about safely calling NotifyInspect() to avoid this Blizzard error in particular right?

Edit: It seems this bug will be fixed in MoP
(5.0.1.15589) AddOns/Blizzard_InspectUI/InspectGuildFrame.lua Line 7

[Torhal]

Originally Posted by gnomi123

As a workaround, I simply used SetCVar("ScriptErrors", "0") to prevent any luaerrors to show up.

...which makes any other AddOn your users have installed do the same. Ugh.

[gnomi123]

Thanks a lot, Ketho. That is the answer I needed.
The remaining problem is, that GetInventoryItemLink(name, slot) sometimes returns the item which was used for mogging, not the one with the right stats. Does someone know how to deal with that?

[oscarucb]

Originally Posted by Ketho

I don't know what InspectFix does exactly, but ..

in one of my addons I use a workaround, by setting InspectFrame.unit to yourself
This should at least prevent InspectGuildFrame_Update() line 18 from giving an error

Setting it to "player" should be safer than e.g. "none", "target" or the applicable unit id, since otherwise it still has a chance to give an error a bit further up at line 25

This is a dangerous suggestion. In general addons have no business blindly modifying private members of FrameXML classes. However if you choose to follow this strategy it is VERY important that you never modify InspectFrame.unit while the InspectFrame is shown - I've seen two separate addons do that in a broken attempt to silence this error, and it can cause the Inspect window to break in VERY strange ways.

[Phanx]

Originally Posted by oscarucb

This is a dangerous suggestion.

Less dangerous than setting the ScriptErrors cvar to 0... at least if you break the inspect frame, the problem is obvious to you (and your users). If you simply hide the problem, it becomes much more difficult to even tell that a problem is happening at all.

Plus, even if you interfere with other inspect addons, I'd have to say that's better than hiding errors from all addons, most of which have nothing to do with inspecting.

[oscarucb]

Originally Posted by Phanx

Less dangerous than setting the ScriptErrors cvar to 0...

Yes, that goes without saying - ScriptErrors is a user setting, one that addons have no business changing without the user's consent.