Go Back   WowAce Forums > Official Addon Threads > General AddOns
General AddOns Authors, post your release ready addons here to get feedback or just to let everyone know about it.

Reply
 
Thread Tools
Old 2 Weeks Ago   #3091
angelife
Newbie
 
Join Date: Feb 2009
Posts: 1
Default Re: Recount

about recountguessedabsorb.

two question.

1# twin shield, i suppose adding the eight spellid of the different shields would show them more or less properly on the guessedabsorb page?

2# druid savage roar, again adding the spellid to the lua should do it, here my question is would it be calculated right? because *often* when multitanking a SINGLE shield absorb it's damage from MULTIPLE sources, IE if i have a savage defense that absors, say, 1500 damage and in a timeframe of 0.1seconds i receive 4 attacks, each of these will be reduced by 1500, whereas "by tooltip" i should have absorbed only 1500 from the very first one.
angelife is offline   Reply With Quote
Old 2 Weeks Ago   #3092
mysticalos
Member
 
Join Date: Jan 2008
Posts: 10
Default Re: Recount

Shields are relitively easy

[65874] = 175000,
[65858] = 175000,
[67257] = 300000,
[67260] = 300000,
[67256] = 700000,
[67259] = 700000,
[67261] = 1200000,
[67258] = 1200000,

then watch events SWING_MISSED, RANGE_MISSED, SPELL_MISSED, SPELL_PERIODIC_MISSED in combat log, subtrack damage from known shield HP (based on spellid chart above). should be able to fairly accurately measure shield dps, and even show in recount who did x damage to shield. I think personally recount should put in a little hack that shows the shield as a mob, that way i can spam "shield took damage from who" in raid and see who's not pulling their weight when they fail at shields on heroic 25.

just adding them to guessedabsorbs probably won't work, since the twins shield doesn't use the typical "ABSORB" functions, it uses MISSED.

Last edited by mysticalos; 2 Weeks Ago at 08:15 PM.
mysticalos is offline   Reply With Quote
Old 2 Weeks Ago   #3093
Elsia
Amazing Member
 
Join Date: Dec 2005
Posts: 1,689
Default Re: Recount

If someone could post relevant combat log lines, that be helpful.
Elsia is offline   Reply With Quote
Old 2 Weeks Ago   #3094
Dridzt
Senior Member
 
Dridzt's Avatar
 
Join Date: Nov 2005
Posts: 281
Default Re: Recount

I've created an - unreleased - addon for my guild, this is from the lua file comment section.

Code:
    -- base: timestamp, event, srcGUID, srcName, srcFlags, destGUID, destName, destFlags
    -- prefix: spellID|envType, spellName, spellSchool 
    -- suffix: amount|missType, overkill|amountMiss, school, resisted, blocked, absorbed, critflag, glancflag, crushflag
    --[[
    shield apply example
    timestamp     event              srcGUID            srcName          sFlag    destGUID           destName         dFlag    sID   sName                scl  auratype
    23:37:38.953  SPELL_AURA_APPLIED,0xF1300086C0011A57,"Eydis Darkbane",0x400a48,0xF1300086C0011A57,"Eydis Darkbane",0x400a48,65874,"Shield of Darkness",0x20,BUFF
    
    shield remove example
    timestamp     event              srcGUID            srcName          sFlag    destGUID           destName         dFlag    sID   sName                scl  auratype
    23:37:49.078  SPELL_AURA_REMOVED,0xF1300086C0011A57,"Eydis Darkbane",0x400a48,0xF1300086C0011A57,"Eydis Darkbane",0x400a48,65874,"Shield of Darkness",0x20,BUFF
    
    full absorb example
    timestamp     event        srcGUID            srcName  sFlag destGUID           destName         dFlag    sID   sName             scl  missType amountMiss
    23:37:48.703  SPELL_MISSED,0x04000000000374E0,"Meanmage",0x514,0xF1300086C0011A57,"Eydis Darkbane",0x400a48,42845,"Arcane Missiles",0x40,ABSORB,  5089
    
    partial absorb example (killing blow)
    timestamp     event                 srcGUID              srcName  sFlag destGUID           destName         dFlag    sID   sName             scl  tot  o sc res  b abs
    23:37:49.093  SPELL_DAMAGE,0x04000000000374E0,"Meanmage",0x514,0xF1300086C0011A57,"Eydis Darkbane",0x400a48,42845,"Arcane Missiles",0x40,4120,0,64,1001,0,403,nil,nil,nil
    ]]
    -- Shield of Darkness: 65874/175000, 67257/300000, 67256/700000, 67258/1200000
    -- Shield of Light:    65858/175000, 67260/300000, 67259/700000, 67261/1200000
Edit: As mysticalos said above in my own addon I'm tracking
SPELL_MISSED|SPELL_PERIODIC_MISSED|RANGED_MISSED|S WING_MISSED
for the full absorbs, and
SPELL_DAMAGE|SPELL_PERIODIC_DAMAGE|RANGED_DAMAGE|S WING_DAMAGE
where the destination is the boss and the absorb argument > 0 for tracking removal by destroying (and not by expiration) as well as who delivered the killing blow (on the shield).
__________________
* the poster formerly known as Astaldo

Last edited by Dridzt; 2 Weeks Ago at 11:48 PM.
Dridzt is offline   Reply With Quote
Old 2 Weeks Ago   #3095
Elsia
Amazing Member
 
Join Date: Dec 2005
Posts: 1,689
Default Re: Recount

Thanks. This is in fact perfectly normal absorb handling. Just adding the spellIDs to RecountGuessedAbsorbs should do the trick. Check out the latest commit. Test feedback welcome.

@angelife on savage defense (I assume this is what you meant, savage roar isn't an absorb ability), this should already be tracked.
Elsia is offline   Reply With Quote
Old 2 Weeks Ago   #3096
Lombra
Full Member
 
Lombra's Avatar
 
Join Date: Jan 2006
Location: Sweden
Posts: 142
Default Re: Recount

Hello,
I'd just like to request that the main frame stays open when zoning (at least outdoors, like Dalaran -> Crystalsong Forest) if you have manually shown it. As far as I understand this is because the zone filters. It's a bit annoying having it disappear while flying around.

Thanks
__________________
Grab your sword and fight the Horde!

Shattered Hand-EU
Lombra is offline   Reply With Quote
Old 2 Weeks Ago   #3097
mysticalos
Member
 
Join Date: Jan 2008
Posts: 10
Default Re: Recount

Just curious, why not externalize all the modules like fails and absorbs are. That way someone can check off useless stuff like power gains etc on addon screen. I know you modulized it slightly a while back to delete the unwanted lua files without errors but that's counter intuitive plus needs to be done every time you update recount.
mysticalos is offline   Reply With Quote
Old 2 Weeks Ago   #3098
mysticalos
Member
 
Join Date: Jan 2008
Posts: 10
Default Re: Recount

the shields show up in absorbs but not in a way that's useful at all, it just tells you what you already know, the shield absorbed x damage. But no way to detect damage from who?
mysticalos is offline   Reply With Quote
Old 2 Weeks Ago   #3099
Elsia
Amazing Member
 
Join Date: Dec 2005
Posts: 1,689
Default Re: Recount

Try the latest alpha. It contains an added detail view that shows who did damage to the shield. This solution isn't ideal for a few reasons.

One is that the uses are kind of complementary. It's a different thing if one wants to track absorbs as a defensive stat or as an offensive one (very much comparable to the difference between Damage Done and Damage Taken). So there may be a fairly good argument to be made that this really should be a separate mode.

In any case this version is a proof of concept and I'd be happy to hear if it works as intended.
Elsia is offline   Reply With Quote
Old 2 Weeks Ago   #3100
mysticalos
Member
 
Join Date: Jan 2008
Posts: 10
Default Re: Recount

I'd say damage based absorbs could be moved into normal recount, where as healing etc ones stay in recountabsorbs? you are gonna run into same situation with iCC when you have a boss that uses a mana shield and again recount can't track accurate damage for whole first phase of the encounter. Since dps is something that mod is suppose to measure, it'd be ok there.
mysticalos is offline   Reply With Quote
Reply

Tags
recount damage meter


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT. The time now is 09:11 AM.