LibItemBonus-2.0

[jerry]

LibStub and CallbackHandler-1.0 based version of ItemBonusLib-1.0.

Please report bugs and feature requests here.

Note that Notifications is done now using 3 methods : A CallbackHandler based method :

function foo:OnInitialize()
  LibStub("LibItemBonus-2.0"):RegisterCallback(self, "ItemBonusLib_Update", function () dosomethinghere() end)
end

An AceEvent-3.0 based method, if AceEvent-3.0 is available :

function foo:OnInitialize()
  LibStub("AceEvent-3.0"):Embed(self)
  self:RegisterMessage("ItemBonusLib_Update")
end

function foo:ItemBonusLib_Update()
  dosomethinghere()
end

And finally the previous AceEvent-2.0 method, if AceEvent-2.0 is available :

function foo:OnInitialize()
  AceLibrary("AceEvent-2.0"):Embed(self)
  self:RegisterEvent("ItemBonusLib_Update")
end

function foo:ItemBonusLib_Update()
  dosomethinghere()
end

[jerry]

Originally Posted by Xinhuan

Ahdri, can you type "//ibonus details" without the quotes (yes there are 2 slashes in there, Jerry made a mistake with the slash command)?

Fixed in r68609.

[Lerkur]

I'm using LibItemBonus-2.0 Revision: 70494.

In the function lib:ScanItemLink() in core.lua on line 835 the code for weapon speed reads:

b.WEAPON_SPEED = get_speed(self.tooltip.lefts[i]:GetText())

This was not reading weapon speeds correctly for me on a enUS client. I believe the code should be:

b.WEAPON_SPEED = get_speed(self.tooltip.rights[i]:GetText())

And thanks for the work you have put into this latest version. It's wonderful.

[BestSteve]

Here is the Traditional Chinese(zhTW) parsing pattern.

[Pantheis]

On ONLY my hunter, I get the following errors upon login. The first one happens once, the second two repeat extremely quickly. This ONLY happens on my hunter and I believe it has to do with my Dragonstalker's Leggings (Hunter Tier 2). If I put my Tier 2 leggings into my bank, log out and back in, I do not get any errors.

I should also note that the memory usage of LibItemBonus-2.0 skyrockets right after login and keeps going up to over 15MB before a automatic garbage collection happens, dropping it back to normal, where it then climbs right back up, rinse and repeat.

Any idea?

Thank you!

[2008/04/26 08:27:05-1602-x1]: LibItemBonus-2.0\LibItemBonus-2.0\core.lua:859: attempt to index field '?' (a nil value)
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:914: in function `BuildBonusSet'
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:983: in function `ScanEquipment'
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:58: in function <...ce\AddOns\LibItemBonus-2.0\LibItemBonus-2.0\core.lua:50>

---

[2008/04/26 08:27:05-1602-x742]: table: 116D61D8: Chat Command 'ibonus' already exists, will not overwrite.:
AceConfigCmd-3.0\AceConfigCmd-3.0.lua:711: in function `CreateChatCommand'
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:581: in function `OnInitialize'
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:57: in function <...ce\AddOns\LibItemBonus-2.0\LibItemBonus-2.0\core.lua:50>

---

[2008/04/26 08:27:05-1602-x742]: LibItemBonus-2.0\LibItemBonus-2.0\core.lua:844: attempt to index local 'set' (a nil value)
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:914: in function `BuildBonusSet'
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:983: in function `ScanEquipment'
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:58: in function <...ce\AddOns\LibItemBonus-2.0\LibItemBonus-2.0\core.lua:50>

---

[Xinhuan]

Pantheis, I believe you have some external addon hooking all tooltips (it shouldn't be doing that) and adding additional lines. The item you mentioned has 29 lines in the tooltip, but the code is expecting more than 30 defined lines.

In any case, changing line 27 of core.lua from 30 to something a bit larger, like 35 should fix it.

[Pantheis]

I've got a number of mods installed that add things to tooltips for items. Thank you for clearing up what was happening.

[Zindjorl]

the pattern for the ignore armor effect does not work in the french locale:

pattern = "Vos attaques ignorent (%d)+ points de l'armure de votre adversaire%.", effect = "IGNOREARMOR" },

the working pattern is :

pattern = "Vos attaques ignorent (%d+) points de l'armure de votre adversaire%.", effect = "IGNOREARMOR" },

[Xinhuan]

Bug reported here:

http://www.wowace.com/forums/index.p...6049#msg216049

BUG: Greater Inscription of Faith ( http://www.wowhead.com/?item=28887 ) counting both the +healing and the +damage to +healing. Meaning WoWEquip will count this as 44 +healing.

[Gabriel]

Getting the following error on my Hunter only, I have 9 lvl 70s of each class and my Hunter is the only one to throw this error on login,

[2008/08/20 18:03:53-2512-x2]: LibItemBonus-2.0\LibItemBonus-2.0\core.lua:627: attempt to index upvalue 'L' (a nil value)
(tail call): ?:
AceEvent-2.0-66043 (Ace2):910: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:903>

---