Go Back   WowAce Forums > Addon Chat > Libraries
Libraries Threads for new libraries and mixins.

Reply
 
Thread Tools
Old 05-04-2008   #1
DathRarhek
Junior Member
 
Join Date: Feb 2008
Posts: 53
Default LibResComm-1.0

Project: http://www.wowace.com/projects/librescomm-1-0/
API description: http://www.wowace.com/projects/libre...i-description/
Requires: LibStub CallbackHandler


LibResComm keeps track of resurrection and soulstones in a group. It broadcasts this using the CTRA res protocol that CTRA and oRA2 use too. It will not send messages when either of those are active.

BUGS:
- The endTime for resurrections casted by players that use oRA2 will not be accurate. This is because oRA2 sends its comm message on SPELLCAST_SENT and not SPELLCAST_START

- Resurrections that are succesfull will not trigger ResComm_ResEnd() for CTRA users. This is because CTRA only sends it on SPELLCAST_STOP.

Last edited by DathRarhek; 05-11-2009 at 11:22 PM.
DathRarhek is offline   Reply With Quote
Old 05-10-2008   #2
saroz2
Hero Member
 
Join Date: Sep 2008
Posts: 653
Default Re: LibResComm-1.0

Really needs NORESSED before it becomes useful, would like:

:HasRecovery(unit) - Unit has SS or ank option
:CanResurrect(unit) - Use has popup from a res (ResComm_Ressed)

Is combat res implemented?
saroz2 is offline   Reply With Quote
Old 05-10-2008   #3
DathRarhek
Junior Member
 
Join Date: Feb 2008
Posts: 53
Default Re: LibResComm-1.0

Why is NORESSED needed so badly? NORESSED is used for when the accept resurrection or use ankh/ss has been declined. The times it is used is very small, because who declines a res? I'll implent it tho.

I can add those two functions. It would require registering for UNIT_HEALTH tho. And what you won't be able to do is listen for UNIT_DEATH and then expect those two functions to return the correct message right away, because you have to deal with latency. That's why I decided to go with callbackhandler events in the first place.

Rebirth is implemented.
DathRarhek is offline   Reply With Quote
Old 05-10-2008   #4
saroz2
Hero Member
 
Join Date: Sep 2008
Posts: 653
Default Re: LibResComm-1.0

Resurrections time out, it's needed to see when people are nolonger able to res.

You wouldn't need to register UNIT_HEALTH, simply register when the popup box disappear (NORESSED)
saroz2 is offline   Reply With Quote
Old 05-11-2008   #5
DathRarhek
Junior Member
 
Join Date: Feb 2008
Posts: 53
Default Re: LibResComm-1.0

Yes, they time out. Someone has to be afk for it to happen. It?s a border case tho and hardly breaking the usability of the lib. I?ll add it as soon as I get back to my game box.

You?re right about not needing UNIT_HEALTH. I?m still wondering what use you have for those two functions?
DathRarhek is offline   Reply With Quote
Old 05-11-2008   #6
saroz2
Hero Member
 
Join Date: Sep 2008
Posts: 653
Default Re: LibResComm-1.0

Quote:
Originally Posted by Polleke
Yes, they time out. Someone has to be afk for it to happen. It?s a border case tho and hardly breaking the usability of the lib. I?ll add it as soon as I get back to my game box.

You?re right about not needing UNIT_HEALTH. I?m still wondering what use you have for those two functions?
You'd be surprised how often NORESSED is sent (afk, res is bugged, user misclicks), it happens a lot, and it's _very_ useful - why NOT implement it? I could finally get rid of having to depend on oRA2 for res messages.

I guess I can live without the two functions and make my own based on the events fired.
saroz2 is offline   Reply With Quote
Old 05-11-2008   #7
saroz2
Hero Member
 
Join Date: Sep 2008
Posts: 653
Default Re: LibResComm-1.0

Suggesting: ResComm_ResExpired() or ResComm_ResCancelled()
saroz2 is offline   Reply With Quote
Old 05-12-2008   #8
DathRarhek
Junior Member
 
Join Date: Feb 2008
Posts: 53
Default Re: LibResComm-1.0

OK. ResComm_ResExpired(name) added for NORESSED. Credits to oRA2 for the hooks.
DathRarhek is offline   Reply With Quote
Old 10-10-2008   #9
Dridzt
Hero Member
 
Dridzt's Avatar
 
Join Date: Nov 2005
Posts: 866
Default WotLK bug with static popups

The .OnShow handlers for StaticPopupDialogs need 'self' reference added.
There's 4 of them starting around line 276 in r39.

Posting the change for ["RESURRECT"] as an example.
The same change is needed for the other 3 (NO_SICKNES, NO_TIMER and DEATH)

Code:
local res = StaticPopupDialogs["RESURRECT"].OnShow
StaticPopupDialogs["RESURRECT"].OnShow = function(self)
    lib:popupFuncRessed()
    res(self)
end
This is for the WotLK beta/ 3.0.2 (and soon to be live) PTR.
Dridzt is offline   Reply With Quote
Old 10-17-2008   #10
DathRarhek
Junior Member
 
Join Date: Feb 2008
Posts: 53
Default Re: LibResComm-1.0

Thanks for pointing that out.

Also hopefully did a correct fix of the WorldFrame hook.
DathRarhek is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 07:30 PM.