LibResComm-1.0

[DathRarhek]

Project: http://www.wowace.com/projects/librescomm-1-0/
API description: http://www.wowace.com/projects/libre...i-description/
Requires: LibStub CallbackHandler

LibResComm keeps track of resurrection and soulstones in a group. It broadcasts this using the CTRA res protocol that CTRA and oRA2 use too. It will not send messages when either of those are active.

BUGS:
- The endTime for resurrections casted by players that use oRA2 will not be accurate. This is because oRA2 sends its comm message on SPELLCAST_SENT and not SPELLCAST_START

- Resurrections that are succesfull will not trigger ResComm_ResEnd() for CTRA users. This is because CTRA only sends it on SPELLCAST_STOP.

[saroz2]

Really needs NORESSED before it becomes useful, would like:

:HasRecovery(unit) - Unit has SS or ank option
:CanResurrect(unit) - Use has popup from a res (ResComm_Ressed)

Is combat res implemented?

[DathRarhek]

Why is NORESSED needed so badly? NORESSED is used for when the accept resurrection or use ankh/ss has been declined. The times it is used is very small, because who declines a res? I'll implent it tho.

I can add those two functions. It would require registering for UNIT_HEALTH tho. And what you won't be able to do is listen for UNIT_DEATH and then expect those two functions to return the correct message right away, because you have to deal with latency. That's why I decided to go with callbackhandler events in the first place.

Rebirth is implemented.

[saroz2]

Resurrections time out, it's needed to see when people are nolonger able to res.

You wouldn't need to register UNIT_HEALTH, simply register when the popup box disappear (NORESSED)

[DathRarhek]

Yes, they time out. Someone has to be afk for it to happen. It?s a border case tho and hardly breaking the usability of the lib. I?ll add it as soon as I get back to my game box.

You?re right about not needing UNIT_HEALTH. I?m still wondering what use you have for those two functions?

[saroz2]

Originally Posted by Polleke

Yes, they time out. Someone has to be afk for it to happen. It?s a border case tho and hardly breaking the usability of the lib. I?ll add it as soon as I get back to my game box.

You?re right about not needing UNIT_HEALTH. I?m still wondering what use you have for those two functions?

You'd be surprised how often NORESSED is sent (afk, res is bugged, user misclicks), it happens a lot, and it's _very_ useful - why NOT implement it? I could finally get rid of having to depend on oRA2 for res messages.

I guess I can live without the two functions and make my own based on the events fired.

[saroz2]

Suggesting: ResComm_ResExpired() or ResComm_ResCancelled()

[DathRarhek]

OK. ResComm_ResExpired(name) added for NORESSED. Credits to oRA2 for the hooks.

[Dridzt]

The .OnShow handlers for StaticPopupDialogs need 'self' reference added.
There's 4 of them starting around line 276 in r39.

Posting the change for ["RESURRECT"] as an example.
The same change is needed for the other 3 (NO_SICKNES, NO_TIMER and DEATH)

local res = StaticPopupDialogs["RESURRECT"].OnShow
StaticPopupDialogs["RESURRECT"].OnShow = function(self)
    lib:popupFuncRessed()
    res(self)
end

This is for the WotLK beta/ 3.0.2 (and soon to be live) PTR.

[DathRarhek]

Thanks for pointing that out.

Also hopefully did a correct fix of the WorldFrame hook.