AcceptGroup() and StaticPopup_Hide()

[DigitalSorceress]

I've got a feature to auto accept group invites in my MultiTool addon if certain conditions are met...

self:RegisterEvent("PARTY_INVITE_REQUEST", "confirmPartyInvite")

function MultiTool:confirmPartyInvite(info, sender)

  if (self.db.profile.groupRejectFlag and not self:isInWhiteList(sender)) then
    DeclineGroup()
    StaticPopup_Hide("PARTY_INVITE")
    return
  elseif (self.db.profile.groupFlag and self:isInWhiteList(sender)) then
    AcceptGroup()
    StaticPopup_Hide("PARTY_INVITE")
    return
  end
end

My problem is that it looks as though the call to StaticPopup_Hide("PARTY_INVITE") is happening so soon after AcceptGroup() that AcceptGroup() ends up getting overridden by the popup hide.

I can put in some kind of delay, or otherwise change the way the code works and probably get it working, but I wanted to post here in case either someone else already figured it out, or else to let folks know that it appears there was some undocumented (as far as I can see) change in the way the StaticPopup_Hide("PARTY_INVITE") is being handled.

[Dridzt]

I put an OnUpdate in my code and check at 0.2 intervals for GetNumPartyMembers()>0 before hiding the static popup.

I only SetScript the OnUpdate in the PARTY_INVITE_REQUEST event
and nil it after hiding the popup.

[Borlox]

Putting the following code before the call to StaticPopup_Hide should prevent the Popup from declining the invite:

for i=1, STATICPOPUP_NUMDIALOGS do
    local dlg = _G["StaticPopup"..i]
    if dlg.which == "PARTY_INVITE" then
        dlg.inviteAccepted = 1
        break
    end
end

It loops through all StaticPopups and sets the inviteAccepted flag for the one that is showing the invite message.

[DigitalSorceress]

Thank you both for the suggestions.

I was thinking along slightly different lines, but I think either of these will work out better for me.

Still curious if 3.1 just plain changed something, or if I've had broken code all along, but was getting away with it until high server lag during patch day caused the "brokenness" to show through.

[Dridzt]

Borlox workaround is more elegant.

[Tekkub]

I'm going to dig into the default UI later tonight and see EXACTLY what it does now, so that we can duplicate that.

[OrionShock]

while it might be a bit hacky, why not just use the static popu's own scripts?

You loop though it to find the dialoug, why not just call the accept buttons :Click() script?

[Farmbuyer]

Originally Posted by DigitalSorceress

Still curious if 3.1 just plain changed something, or if I've had broken code all along, but was getting away with it until high server lag during patch day caused the "brokenness" to show through.

The 'Group' module in Automaton (not yet updated for 3.1) is suffering from a similar problem. Going to add the inviteAccepted workaround locally and see if it helps (it should).

edit: it does. left a comment on the automaton wowace page.

[weab]

I registered the PARTY_MEMBERS_CHANGED event and close the static popup in Automaton that way. Works dandy.

[jerry]

Why not simply:

UIParent:UnregisterEvent"PARTY_INVITE_REQUEST"

and choose yourself wether or not showing a Dialog in your code ?