Grid2Broker

[Azethoth]

Grid2Broker

Features:

• launch the config
• toggles grid frame movement

[Tekkub]

Stupid question time... why is this separate from Grid2? We're talking like 65 KiB of code here...

[Elsia]

I like it separate... hence why there is a Broker_Recount...

People have drawn up bloat battles over far less than 65KiB around here also...

But yeah in terms of lib reward points, we should include it. *wink wink nudge nudge*

Really separate is fine. Many people do not use any broker display at all. Those who do can grab the broker separately, or even replace/pick another solution. In case of recount there are actually multiple broker solutions that people can pick from. Good stuff.

But it's taste. In tourguide I never use the (is it two?) brokers it provides by default because the tracking bar already offers all the config access I need. So I could actually do without any brokers in tourguide.

It's a taste thing at the end of the day.

[Tekkub]

LDB's primary design was to be as small as possible so that people wouldn't feel the need to separate things out like this... FBP put people in the mindset that it needs to be a second addon because it was so much crap to embed just to get a launcher.

Broker drives TG, it wouldn't work without it. Even if you don't realize it, you're using LDB when you use TG.

[Phanx]

Originally Posted by Elsia

[...] tiring and unecessary politics of you trying to twist everybody's arm to hard-embed launchers.

Honestly, I don't see what the fuss is about. All I've ever seen on this topic has been Tekkub trying to communicate his vision for the library that he wrote, and you guys whining that he's trying to force you to do stuff. In this case, the discussion (and the separate plugin) is even more ridiculous than usual -- Grid2 already embeds LibStub and CallbackHandler-1.0 for other reasons, so embedding LibDataBroker-1.1 would entail nothing more than the inclusion of a tiny 3k file and about 20 lines of code for the actual data object.

Back on topic:

- The plugin is an obvious copy/paste of your currency pluger, Az, and it looks like you forgot to change some stuff. The tooltip's name, for instance, still refers to the currency plugin. This may cause problems for users of both?

- The use of LibQTip seems like complete overkill for adding three lines of plain text to a non-interactive tooltip. Why not use the OnTooltipShow method, and then the normal AddLine and AddDoubleLine features of the GameTooltip?

- The OnClick handler is pretty convoluted. Rather than using multiple if-then-else conditions and have most of them do the same thing (open the options), why not just do one if button == "LeftButton" and IsShiftKeyDown() then (toggle the lock) else (open the options) end ?

[Tekkub]

Originally Posted by Phanx

Honestly, I don't see what the fuss is about.

Indeed... and to that extent, the question was directed at the addon's author, not you Elisa. If it had been your addon, I would not have even bothered. I'm curious what HIS reason is... if he seriously does not want the "bloat" of embedding LDB and his launcher code, or if it's just habit from the days of making FuBar launchers.

[Azethoth]

Yoga time everybody! Sun pose now, into downward dog! Eventually this will provide some minimal config functionality as well. It will most certainly not remain svelte, hence including it separately. Ill upgrade to the click version of qtip when the time comes.

In addition, Grid2 has a strict separation between the actual engine and the lod config for it. Another reason to keep this config stuff separate.

The related configmode support however is svelte and will remain that way so its in the addon itself. For people not using brokers, it provides an alternative to the current locking feature.

[Torhal]

Originally Posted by Azethoth

<snip> Ill upgrade to the click version of qtip when the time comes. <snip>

Don't - it's deprecated. Look at the API for LibQTip, specifically :SetCellScript(), :SetLineScript(), and :SetColumnScript().

[Tekkub]

Is the config that heavy that you need it to be a separate LoD addon? If it is, maybe it'd be best to direct effort into cleaning up the config code. Config panels can be made very cheaply, and the cost can be delayed until the frame's first OnShow (i.e. when it's actually used)... giving the same overall effect as a LoD addon without all that messy second addon stuff.

[OrionShock]

hell.. why even embed LDB into the addon. Only displays really need it, Let the display bring the lib just have the addon provide the data table if the lib exists OnEnable()

That cuts down on bloat. If the lib ain't there in onEnable, then don't allocate one.