Grid

[MSaint]

Hey again guys. I hope my insistance is not too annoying. Just want to show you the problem I was referring to upthread with the pets, still there in r1364 (these are both Group 10 w/pets):



And with my posted changes:



Now, I'm guessing you guys found something wrong with my code, in which case I apologize. Let me know if it is something I can look at or help with.

Thanks as always for all your work on this.

[Phanx]

Originally Posted by Stanzilla

The Grid frame orientation settings are interchanged

Could you be more specific? No options have been changed that I'm aware of.

The other error you posted was already reported in the bug tracker.

Originally Posted by MSaint

... the problem I was referring to upthread with the pets, still there in r1364 ... I'm guessing you guys found something wrong with my code

Nope, I just haven't had time to do anything with your code. The changes in r1363-1365 were made by Cladhaire, the author of Clique, to resolve issues with frames failing to update when Clique was enabled. I'll try to get to the pet stuff tomorrow.

[Stanzilla]

Originally Posted by Phanx

Could you be more specific? No options have been changed that I'm aware of.

The other error you posted was already reported in the bug tracker.



Nope, I just haven't had time to do anything with your code. The changes in r1363-1365 were made by Cladhaire, the author of Clique, to resolve issues with frames failing to update when Clique was enabled. I'll try to get to the pet stuff tomorrow.

horizontal and vertical seem to be mixed up

[Phanx]

Again:

Please don't post here about issues caused by outdated plugins.

This thread is for discussion about Grid itself only. If you want to talk about a plugin, do so in the plugin's thread if it has one, or in the Help updating plugins for 4.0 thread if it doesn't. I've moved the latest batch of plugin-related posts to that thread.

[Phanx]

Originally Posted by Stanzilla

horizontal and vertical seem to be mixed up

I'm not seeing that problem; I even toggled the option back and forth a few times, with no problems.

[Phanx]

Originally Posted by MSaint

Ok, here is the fixed up version of CreateHeader():

Committed in r1370. I noticed that pets are still spaced out in 5-man party groups, but since that results in the pet frame being next to/underneath their owner's frame, and it's only 5 players/pets, I think that's fine.

If nobody reports any new issues in the next 8 hours or so, I'll tag a release.

[wyldphire1]

So... Are the Incoming Heals going to be worked out so that they accurately display incoming heals?

[Phanx]

Ask Blizzard, not us. The incoming heal values now come directly from the game client, so the numerous issues with their accuracy are entierly Blizzard's fault. I'd assume that they're still working on it, since it is new functionality, and that it'll be smoothed out by the time Cataclysm launches. Beyond that, there's nothing we can do about it.

[wyldphire1]

Originally Posted by Phanx

Ask Blizzard, not us. The incoming heal values now come directly from the game client, so the numerous issues with their accuracy are entierly Blizzard's fault. I'd assume that they're still working on it, since it is new functionality, and that it'll be smoothed out by the time Cataclysm launches. Beyond that, there's nothing we can do about it.

Dang! Shitty. Alrighty. Thanks for the update though. I figured someone has asked about this, but I noticed this forum is over 300 pages, so I just figured I would ask instead of troll through them all. LOL.

[Phanx]

Scroll to the top of the page and click "Search this Thread".