These forums are in read-only mode. Please see this news post for more information.

New forums can be found here


Go Back   WowAce Forums > General > General Chat

Reply
 
Thread Tools
Old 08-15-2016   #1
vvv444
Newbie
 
Join Date: Oct 2014
Posts: 3
Default Please fix Curse to properly handle -nolib for manual uploads

Hi,

Currently, Curse does not handle -nolib versions for manually uploaded files but only for files produced by the automatic packager. In case of manual upload Curse Client installs the latest file uploaded no matter what.

I found explanation on this thread:
Quote:
Originally Posted by Torhal View Post
No. There are under-the-hood flags for -nolib files which the Client looks at when determining what to install.
Can't you please just fix it so that the system sets these "under-the-hood" flags on manual upload? I believe checking the file name for "-nolib" suffix should be enough.

Best regards,
vvv444
vvv444 is offline   Reply With Quote
Old 08-15-2016   #2
Nevcairiel
Super Moderator
 
Nevcairiel's Avatar
 
Join Date: Aug 2005
Posts: 1,908
Default Re: Please fix Curse to properly handle -nolib for manual uploads

Instead, nolib should really be removed as a feature.
__________________
Author/Maintainer of Ace3, Bartender4, Mapster, Quartz, HotCandy, and various small and helpful addons.
You can Donate if you want, any help is appreciated!
Nevcairiel is offline   Reply With Quote
Old 08-15-2016   #3
vvv444
Newbie
 
Join Date: Oct 2014
Posts: 3
Default Re: Please fix Curse to properly handle -nolib for manual uploads

Why? Can you please explain?
I do see it good for two reasons:
1. It significantly improves UI load time.
2. For me as a developer, it is much easier to work when I have one copy of library around instead of say 30!
vvv444 is offline   Reply With Quote
Old 08-15-2016   #4
Nevcairiel
Super Moderator
 
Nevcairiel's Avatar
 
Join Date: Aug 2005
Posts: 1,908
Default Re: Please fix Curse to properly handle -nolib for manual uploads

Developers can take care of their setup manually, users often just screw up their setup with options they don't understand.

The load time argument is mostly bogus, it doesn't have a significant influence as none of the code of the duplicate libraries is executed - assuming those libraries are written properly to bail out early
__________________
Author/Maintainer of Ace3, Bartender4, Mapster, Quartz, HotCandy, and various small and helpful addons.
You can Donate if you want, any help is appreciated!
Nevcairiel is offline   Reply With Quote
Old 08-17-2016   #5
Phanx
Seal Cub Clubbing Club
 
Phanx's Avatar
 
Join Date: May 2005
Posts: 8,483
Default Re: Please fix Curse to properly handle -nolib for manual uploads

Quote:
Originally Posted by Nevcairiel View Post
The load time argument is mostly bogus, it doesn't have a significant influence as none of the code of the duplicate libraries is executed - assuming those libraries are written properly to bail out early
I haven't tested recently, but I did time this 4-5 years ago, and there was a very noticable difference (several seconds, but I can't find the thread/post to get exact numbers) between otherwise-identical embedded vs nolib setups. I was already running WoW on an SSD at that point; the situation will be even worse for HDD users.

Nowadays I don't bother with a nolib setup, because... well, I don't actually even play now, but at some point I just stopped caring about a few extra seconds at the loading screen, and decided it wasn't worth the effort maintaining a full nolib setup.
__________________
Author/maintainer of Grid, PhanxChat, and many more. | PM me on CurseForge
Troubleshoot an addon | Turn any code into an addon | More addon resources
Need help with your code? Attach or paste your whole, real files.
Please don't PM me about addon bugs, requests, or code help. Post a comment, ticket, or thread instead!

Last edited by Phanx; 08-17-2016 at 04:35 AM.
Phanx is offline   Reply With Quote
Old 08-17-2016   #6
Farmbuyer
Amazing Member
 
Farmbuyer's Avatar
 
Join Date: Feb 2005
Posts: 1,183
Default Re: Please fix Curse to properly handle -nolib for manual uploads

The "time to execute" has never been the savings for nolib. It's the time spent reading in the full contents of the files, parsing them, and generating bytecode. That will happen for every file listed in the toc, unconditionally, regardless if "whoops, nvm, return" is executed a few instructions in.
__________________
In wizardry, one must often be willing to consider serendipitous events as unqualified successes. -Vaarsuvius
Farmbuyer is offline   Reply With Quote
Old 08-20-2016   #7
vvv444
Newbie
 
Join Date: Oct 2014
Posts: 3
Default Re: Please fix Curse to properly handle -nolib for manual uploads

Quote:
Originally Posted by Nevcairiel View Post
Developers can take care of their setup manually, users often just screw up their setup with options they don't understand.

The load time argument is mostly bogus, it doesn't have a significant influence as none of the code of the duplicate libraries is executed - assuming those libraries are written properly to bail out early
1. Well, as others pointed out, it does influence the load time, since it has nothing to do with execution time. Maybe I even perform a benchmark tests and post some actual times compared...

2. True that developers setup manually, but nolib is very comfortable.

3. Claim "users can screw up" is universal for so much things... I believe that this option is already disabled by default in Curse Client, so I see no problem with this.

4. In any case, it should be either official Curse decision to remove this feature (which would be really bad call IMHO) or keep it. And if the official position is to keep it, the inability to upload this manually is definitely kind of a bug. So how can we ask the developers to tend to it? Is this forum the right place?

Nevcairiel, are you a developer on Curse?
vvv444 is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 08:19 PM.